fix style and false warning in check_5_3 #491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @konstruktoid , I'm testing a container created with the command:
, where
CAP_SYS_CHROOT
is a default capability for containers.In this case, running check_5_3 should not give warnings ( also I noticed that the default capabilities are trimmed ), but in fact, it gives output like:
( If then adding some other extra caps, the output will be like:
CapAdd=[CAP_CAP_SYS_ADMIN]
)This is because users may give cap args in the long form of
CAP_*
.This commit will deal with this scenario and fix the false warning ( already tested with input args
CAP_SYS_CHROOT/SYS_CHROOT, CAP_SYS_ADMIN
).Also, it fixed the code style (
{{ .HostConfig.CapAdd}}
->{{ .HostConfig.CapAdd }}
)