[27.x backport] feat: build Fedora 41 RPM packages #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thaJeztah
commented
Sep 4, 2024
thaJeztah
commented
- backport [master] feat: build Fedora 41 RPM packages (carry #1055) #1058
Signed-off-by: Robert Sturla <robertsturla@outlook.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 36c9cf2) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This is the equivalent of docker/containerd-packaging#390 for containerd packages, but unlike for containerd packages, we currently do not run into this issue when building docker-ce packages. We're installing this as a precaution, but perhaps it's not needed. go1.21 and up have a patch that enforces the use of ld.gold to work around a bug in GNU binutils. See; - golang/go#22040. - golang/go@cd77738 Fedora 41 and up has a fixed version of binutils, and no longer requires that patch, but may fail without ld.gold installed; /usr/bin/gcc -Wl,-z,now -Wl,-z,nocopyreloc -fuse-ld=gold -o $WORK/b001/exe/a.out -rdynamic /tmp/go-link-1738353519/go.o /tmp/go-link-1738353519/000000.o /tmp/go-link-1738353519/000001.o /tmp/go-link-1738353519/000002.o /tmp/go-link-1738353519/000003.o /tmp/go-link-1738353519/000004.o /tmp/go-link-1738353519/000005.o /tmp/go-link-1738353519/000006.o /tmp/go-link-1738353519/000007.o /tmp/go-link-1738353519/000008.o /tmp/go-link-1738353519/000009.o /tmp/go-link-1738353519/000010.o /tmp/go-link-1738353519/000011.o /tmp/go-link-1738353519/000012.o /tmp/go-link-1738353519/000013.o /tmp/go-link-1738353519/000014.o /tmp/go-link-1738353519/000015.o /tmp/go-link-1738353519/000016.o /tmp/go-link-1738353519/000017.o /tmp/go-link-1738353519/000018.o /tmp/go-link-1738353519/000019.o /tmp/go-link-1738353519/000020.o /tmp/go-link-1738353519/000021.o /tmp/go-link-1738353519/000022.o /tmp/go-link-1738353519/000023.o /tmp/go-link-1738353519/000024.o -O2 -g -lresolv -O2 -g -lpthread -O2 -g -ldl -O2 -g collect2: fatal error: cannot find 'ld' Fedora's build of Go carries a patch for that, but it's not (yet) in upstream; - https://src.fedoraproject.org/rpms/golang/blob/a867bd88a656c1d6e91e7b18bab696dc3fcf1e77/f/0006-Default-to-ld.bfd-on-ARM64.patch - https://src.fedoraproject.org/rpms/golang/c/a867bd88a656c1d6e91e7b18bab696dc3fcf1e77?branch=rawhide Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 563068b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@vvoland this one's green as well 🥳 |
sam-thibault
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.