all: add rules for docker-model-plugin packages#1190
Conversation
xenoscopic
force-pushed
the
docker-model-packaging
branch
from
eb469a7 to
91d1f54
Compare
|
Hey @neersighted can we wait a few more hours before merging? We're going to bump the version tag in just a bit. Then we should be at feature-complete. |
deb/common/control
Outdated
| Recommends: docker-buildx-plugin, | ||
| docker-compose-plugin | ||
| docker-compose-plugin, | ||
| docker-model-plugin |
There was a problem hiding this comment.
One thing I was considering, but perhaps I'm over-thinking; as the model CLI is still beta, should we already add it to "recommends" here, or should we leave it (for now) handle this through the get.docker.com script (adding it as "recommends" once it's out of beta / nearing non-beta?
There was a problem hiding this comment.
I'm okay with leaving it out of recommends, though I think we'll probably try to get it added to the Docker CE install instructions. CC @francesco-corti or @kiview in case they have any thoughts.
There was a problem hiding this comment.
We could make it Suggest (weaker than Recommends)
@neersighted @tianon any thoughts?
|
Sounds good; I was going to wait for @thaJeztah to take a look as well if possible. |
xenoscopic
force-pushed
the
docker-model-packaging
branch
from
91d1f54 to
3218864
Compare
|
I've bumped the Model CLI version to v0.1.23 and downgraded the Deb/RPM recommendations to suggestions. I think this is okay to merge once the reviewers feel it's ready. |
xenoscopic
force-pushed
the
docker-model-packaging
branch
from
3218864 to
908e995
Compare
Docker Model Runner's support for Docker CE is going to require availability of the docker model command, so this commit adds the new package by following the mechanisms used by buildx and compose. Signed-off-by: Jacob Howard <jacob.howard@docker.com>
xenoscopic
force-pushed
the
docker-model-packaging
branch
from
908e995 to
cefea11
Compare
|
once packaged are up (as part of the docker-ce release), we should als update https://github.com/docker/docker-install to include the package by default |
|
@neersighted gave me an "LGTM" on slack; let me bring this one in |
5 participants
- What I did
I added a
docker-model-pluginpackage in support of Docker Model Runner's upcoming support for Docker CE.- How I did it
I tried to emulate the structure of the
docker-buildx-pluginanddocker-compose-pluginbuilds / specs (primarily compose). One small ugly bit is that the source repo is calledmodel-cli, and Go requires it retain that name, so I've had to use asrc/github.com/docker/model-clipath for the code, but for all the variables and specs I've omitted the-clisuffix and just usedmodel/MODELnomenclature.- How to verify it
The package should build successfully on all supported target distros.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)