Add initial scripts for Fedora 29 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
force-pushed
the
fedora29
branch
from
7d2756d
to
a5a6e0a
Compare
seemethere
changed the title
seemethere
changed the title
seemethere
force-pushed
the
fedora29
branch
from
a5a6e0a
to
3b5c0c4
Compare
jose-bigio
reviewed
Sep 17, 2018
| @@ -69,6 +70,14 @@ fedora: fedora-28 fedora-27 fedora-26 ## build all fedora rpm packages | |||
| .PHONY: centos | |||
| centos: centos-7 ## build all centos rpm packages | |||
|
|
|||
| .PHONY: fedora-29 | |||
There was a problem hiding this comment.
Should add fedora-29 to the fedora target.
Although I'm not sure if we use that target.
There was a problem hiding this comment.
We don't, we should probably just remove it
|
This needs to be rebased! |
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
|
@jose-bigio rebased! |
|
Hi, Thank you for your work! Cheers, |
|
|
Manage it via: # from F29
dnf install https://download.docker.com/linux/fedora/29/x86_64/nightly/Packages/docker-ce-cli-0.0.0.20181027050239.c7c18e3-0.fc29.x86_64.rpm
# from F28, as the docker-ce requires `containerd.io` to be installed (instead of containerd in system?)
dnf install https://download.docker.com/linux/fedora/28/x86_64/stable/Packages/containerd.io-1.2.0-2.2.rc.2.1.fc28.x86_64.rpm
# from F29
dnf install https://download.docker.com/linux/fedora/29/x86_64/nightly/Packages/docker-ce-0.0.0.20181027050239.c7c18e3-0.fc29.x86_64.rpmLooks stable, until an official repo will be available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 29 isn't scheduled to GA until 23-10-2018 but let's get ahead of the curve and start building this in our nightly pipelines.
Relates to docker/for-linux#430
Signed-off-by: Eli Uriegas eli.uriegas@docker.com