Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "systemd: add multi-user.target to After list" #514

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 10, 2020

This reverts commit 36bb015, which caused the docker service to not be starting, or delayed starting the service in certain conditions.

relates to / introduced in moby/moby#41297 / #488 systemd: add multi-user.target to After list

fixes / addresses moby/moby#41767 systemctl docker start get stuck in cloud-init
fixes / addresses docker/for-linux#1161 Docker service not starting in centos 7.9
fixes / addresses docker/for-linux#1162 Docker 20.10 daemon takes 5 minutes to start after reboot
fixes / addresses docker/machine#4858 Latest docker release (20.10.0) doesn't work with docker-machine
fixes / addresses home-assistant/supervisor#2359 Supervised installation not working on Docker 20.x

This reverts commit 36bb015,
which caused the docker service to not be starting, or delayed
starting the service in certain conditions.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@tiborvass @chris-crone @tianon PTAL

Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass tiborvass merged commit 747e984 into docker:master Dec 10, 2020
@thaJeztah thaJeztah deleted the revert_after_multiuser branch December 10, 2020 20:24
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Dec 28, 2020
pkgsrc changes:
 - Simplify handling of GITHUB_*/DISTNAME/PKGNAME/GO_DIST_BASE to make it easier
   to follow

Changes:
20.10.1
=======
Builder
-------
 - buildkit: updated to v0.8.1 with various bugfixes moby/moby#41793

Packaging
---------
 - Revert a change in the systemd unit that could prevent docker from
   starting due to a startup order conflict docker/docker-ce-packaging#514
 - buildx updated to v0.5.0 docker/docker-ce-packaging#515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants