Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IL-194 Remove docker-app plugin #548

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

StefanScherer
Copy link
Member

docker app is not maintained, and can sometimes cause performance problems.
We want to remove it from Docker Desktop.

Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
@StefanScherer StefanScherer requested a review from thaJeztah May 25, 2021 09:50
@thaJeztah
Copy link
Member

Do you know if we wanted to add a "stub" script that would print instructions (or a link) on how to install docker app (if we want to include this in 20.10.7 patch release), or only mention in the changelog / release notes?

@thaJeztah
Copy link
Member

if we want to include this in 20.10.7, this needs to be cherry-picked into the 20.10 branch after merged to master

@StefanScherer
Copy link
Member Author

I don't think we need it in 20.10.7 patch release, no hurry. We handle that removal in the Docker Desktop build pipeline right now.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

should at least be fine for master 👍

@thaJeztah thaJeztah merged commit 409ab6c into docker:master Jun 2, 2021
@StefanScherer StefanScherer deleted the remove-docker-app branch June 2, 2021 12:30
@StefanScherer StefanScherer changed the title Remove docker-app plugin IL-194 Remove docker-app plugin Jun 11, 2021
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 4, 2021
- Bump to docker moby 20.10.8
- Drop deprecated and archived app plugin (docker/docker-ce-packaging#548)
- Upgrade buildx to 0.6.1 (docker/docker-ce-packaging#562)

git-svn-id: file:///srv/repos/svn-community/svn@993629 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 4, 2021
- Bump to docker moby 20.10.8
- Drop deprecated and archived app plugin (docker/docker-ce-packaging#548)
- Upgrade buildx to 0.6.1 (docker/docker-ce-packaging#562)



git-svn-id: file:///srv/repos/svn-community/svn@993629 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants