[master] Makefile: enable GOPROXY to work around vanity URL being offline #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The https://honnef.co/go/tools domain looks to be offline, causing projects that do not use vendoring to fail: go: downloading google.golang.org/protobuf v1.27.1 go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 go: google.golang.org/grpc@v1.44.0 requires google.golang.org/genproto@v0.0.0-20200526211855-cb27e3aa2013 requires honnef.co/go/tools@v0.0.0-20190523083050-ea95bdfd59fc: unrecognized import path "honnef.co/go/tools": reading https://honnef.co/go/tools?go-get=1: 502 Bad Gateway make: *** [Makefile:71: manpages] Error 1 For now, let's use the GOPROXY (we should look at making this a build-arg probably) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
FWIW; for some cases (such as a security release, where we may need a temporary fork of dependencies), we may have to override This is just to get CI pass again |
thaJeztah
changed the title
|
Discussing with @crazy-max - we can also specify both as default ( We'll need to try if that works for these situations; let me keep it simple for now (but look at it for a follow-up) |
rumpl
approved these changes
May 5, 2022
crazy-max
approved these changes
May 5, 2022
|
Thx! Let me bring this one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://honnef.co/go/tools domain looks to be offline, causing projects that
do not use vendoring to fail:
For now, let's use the GOPROXY (we should look at making this a build-arg probably)