-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] refactor static packages #835
Open
crazy-max
wants to merge
7
commits into
docker:master
Choose a base branch
from
crazy-max:refactor-static
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Jan 25, 2023
crazy-max
force-pushed
the
refactor-static
branch
3 times, most recently
from
January 25, 2023 14:48
fecf172
to
4b63916
Compare
@thaJeztah As discussed added extra commit to keep the same file format for bundles so for now we keep using current arches to reflect folder structure on download.docker.com Also adds another commit that creates |
crazy-max
force-pushed
the
refactor-static
branch
from
January 25, 2023 14:55
4b63916
to
9087f6b
Compare
Will open follow-ups on release-repo and release-packaging to be sure everything works fine. |
crazy-max
force-pushed
the
refactor-static
branch
2 times, most recently
from
January 25, 2023 15:36
b2b565c
to
ac30efa
Compare
crazy-max
force-pushed
the
refactor-static
branch
3 times, most recently
from
February 6, 2023 16:44
35ee94c
to
a45533a
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
refactor-static
branch
from
February 8, 2023 21:38
a45533a
to
228bcad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #718
closes #665
This is a follow-up #718 and #665. Now that docker-engine supports cross-compilation with
--platform
moby/moby#44546 and compose too docker/compose#9744 we can move on better support for static packages and mutualize job steps and build logic.Versioning for plugins doesn't go through the
gen-static-ver
script. Let me know if we should.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com