Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker.socket to the %preun section #852

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

ruizink
Copy link
Contributor

@ruizink ruizink commented Feb 23, 2023

This PR adds docker.socket to the %preun section of the docker-ce spec, in order to disable the socket upon uninstall.

Fixes #851

Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
@thaJeztah
Copy link
Member

Thank you! I'll dig into these changes a bit, and check up on the documentation for the various RPM flavours we have (sometimes there's some ever-so-slightly differences between versions (Fedora (recent versions) vs CentOS 7 (pretty ancient versions).

I was also curious what the %systemd_preun was meant to do (and if that should take care of these). Still need to read up on that as well, but another maintainer did some initial searching, and found these;

https://github.com/systemd/systemd/blob/9cddd367077f8841b5f84786d113ebc4556b06d3/src/rpm/macros.systemd.in#L64-L70

https://github.com/systemd/systemd/blob/9cddd367077f8841b5f84786d113ebc4556b06d3/src/rpm/systemd-update-helper.in#L20-L26

@ruizink
Copy link
Contributor Author

ruizink commented Jul 5, 2023

Hello.
Any progress on this?
Thanks

@thaJeztah
Copy link
Member

@neersighted ptal 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstalling docker-ce RPM does not disable docker.socket
3 participants