Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] bump compose version to v2.22.0 #946

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Sep 21, 2023

@glours glours requested a review from a team September 22, 2023 14:43
@glours glours self-assigned this Sep 22, 2023
common.mk Outdated Show resolved Hide resolved
sam-thibault
sam-thibault previously approved these changes Sep 24, 2023
@neersighted
Copy link
Member

Copying from Slack:

We have legit CI failures here as Compose now requires Go 1.21; this is blocked until either:

  • We push a version that uses a separate Go compiler for Compose (I'd be okay with this)
  • All other projects (e.g. CLI, Engine, buildx) compile with Go 1.21

Since the second option will likely happen soon (read: days to weeks), @glours expressed he's fine with waiting to get this in.

deb/common/rules Outdated
&& make VERSION=$(COMPOSE_VERSION) DESTDIR=/usr/libexec/docker/cli-plugins build
&& make GO_VERSION=$(GO_VERSION_COMPOSE) VERSION=$(COMPOSE_VERSION) DESTDIR=/usr/libexec/docker/cli-plugins build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably won't work, because both deb and rpm build-tools don't / can't use docker; they're plain make targets (but may be running inside a docker container)

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@thaJeztah
Copy link
Member

oh, LOL, I did a rebase earlier in ca you still wanted to look at a custom option; #953

Let's merge this one

@thaJeztah thaJeztah changed the title bump compose version to v2.22.0 [master] bump compose version to v2.22.0 Oct 12, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f0e566d into docker:master Oct 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants