-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] bump compose version to v2.22.0 #946
Conversation
714019a
to
5e45297
Compare
5e45297
to
10b66c2
Compare
Copying from Slack: We have legit CI failures here as Compose now requires Go 1.21; this is blocked until either:
Since the second option will likely happen soon (read: days to weeks), @glours expressed he's fine with waiting to get this in. |
cc23f4a
to
c52bb28
Compare
deb/common/rules
Outdated
&& make VERSION=$(COMPOSE_VERSION) DESTDIR=/usr/libexec/docker/cli-plugins build | ||
&& make GO_VERSION=$(GO_VERSION_COMPOSE) VERSION=$(COMPOSE_VERSION) DESTDIR=/usr/libexec/docker/cli-plugins build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably won't work, because both deb
and rpm
build-tools don't / can't use docker; they're plain make
targets (but may be running inside a docker container)
c52bb28
to
b38ea1d
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
b38ea1d
to
3e54ed5
Compare
oh, LOL, I did a rebase earlier in ca you still wanted to look at a custom option; #953 Let's merge this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/docker/compose/releases/tag/v2.22.0