Merge pull request #414 from vvoland/ignore-sc2329

Makefile: Ignore SC2329
docker · May 13, 2024 · f2775a0 · f2775a0
2 parents 6d9743e + c428d31
commit f2775a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -3,7 +3,7 @@ VERSION?=
 CHANNEL?=
 
 VOLUME_MOUNTS=-v "$(CURDIR)":/v
-SHELLCHECK_EXCLUSIONS=$(addprefix -e, SC1091 SC1117 SC2317)
+SHELLCHECK_EXCLUSIONS=$(addprefix -e, SC1091 SC1117 SC2317 SC2329)
 SHELLCHECK=docker run --rm $(VOLUME_MOUNTS) -w /v koalaman/shellcheck:stable $(SHELLCHECK_EXCLUSIONS)
 
 ENVSUBST_VARS=LOAD_SCRIPT_COMMIT_SHA

diff --git a/install.sh b/install.sh
@@ -174,12 +174,12 @@ command_exists() {
 # version_gte 23.0 // 0 (success)
 # version_gte 20.10 // 0 (success)
 # version_gte 19.03 // 0 (success)
-# version_gte 21.10 // 1 (fail)
+# version_gte 26.1  // 1 (fail)
 version_gte() {
  if [ -z "$VERSION" ]; then
  return 0
  fi
- eval version_compare "$VERSION" "$1"
+ version_compare "$VERSION" "$1"
 }
 
 # version_compare compares two version strings (either SemVer (Major.Minor.Path),