Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert raspbian changes #25

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

seemethere
Copy link
Contributor

Reverts raspbian changes back to https://apt.dockerproject.org, due to
issues with swarm in the newest release 17.07.0-ce related to issue
moby/swarmkit#2294.

This will stay in place for raspbian until that issue is resolved.

Signed-off-by: Eli Uriegas eli.uriegas@docker.com

ping @alexellis @StefanScherer

Reverts raspbian changes back to https://apt.dockerproject.org, due to
issues with swarm in the newest release 17.07.0-ce related to issue
moby/swarmkit#2294.

This will stay in place for raspbian until that issue is resolved.

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@DieterReuter
Copy link

That's great!

@andrewhsu
Copy link
Contributor

To be clear this PR will still install the 17.05 package from apt.dockerproject.org. This PR is needed so after 17.07 is released, the version of docker-ce installed is still locked to 17.05.

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit c34e43c into docker:master Aug 29, 2017
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense right now.

set -x
echo "$docker_key" | $sh_c 'apt-key add -'
$sh_c "mkdir -p /etc/apt/sources.list.d"
$sh_c "echo deb \[arch=$(dpkg --print-architecture)\] https://apt.dockerproject.org/repo ${lsb_dist}-${dist_version} main > /etc/apt/sources.list.d/docker.list"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we find a solution to provide the jessie DEB for stretch as well. Raspbian recently has switched the new SD card image to stretch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it, official stretch packages probably won't be available until 17.09 though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanScherer look into #27

@seemethere seemethere deleted the revert_raspbian_changes branch August 29, 2017 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants