-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert raspbian changes #25
Conversation
Reverts raspbian changes back to https://apt.dockerproject.org, due to issues with swarm in the newest release 17.07.0-ce related to issue moby/swarmkit#2294. This will stay in place for raspbian until that issue is resolved. Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
d8eff5d
to
37d7820
Compare
That's great! |
To be clear this PR will still install the 17.05 package from apt.dockerproject.org. This PR is needed so after 17.07 is released, the version of docker-ce installed is still locked to 17.05. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense right now.
set -x | ||
echo "$docker_key" | $sh_c 'apt-key add -' | ||
$sh_c "mkdir -p /etc/apt/sources.list.d" | ||
$sh_c "echo deb \[arch=$(dpkg --print-architecture)\] https://apt.dockerproject.org/repo ${lsb_dist}-${dist_version} main > /etc/apt/sources.list.d/docker.list" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we find a solution to provide the jessie DEB for stretch as well. Raspbian recently has switched the new SD card image to stretch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it, official stretch packages probably won't be available until 17.09 though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefanScherer look into #27
Reverts raspbian changes back to https://apt.dockerproject.org, due to
issues with swarm in the newest release 17.07.0-ce related to issue
moby/swarmkit#2294.
This will stay in place for raspbian until that issue is resolved.
Signed-off-by: Eli Uriegas eli.uriegas@docker.com
ping @alexellis @StefanScherer