update script to use .asc, remove gpg as pre-requisite #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current distro versions now allow the GPG key to be stored as an `.asc` file, which simplifies installation. Changing the file extension for the GPG key to .asc lets apt-get know the GPG key is in ASCII armor format, in which case there is no need to "dearmor", and we no longer need gpg as a pre-requisite. Instructions for manual installation on Debian based distros were updated in our documentation through [docker/docs@33befd6]. It's common for users to install packages in a combination of the convenience script and manual (e.g. to update the packages after install, or vice-versa). Given that both the script and the manual steps configure the repository, we want those steps to align, otherwise (potentially?) warnings / errors may occur; $ sudo apt-get update E: Conflicting values set for option Signed-By regarding source https://download.docker.com/linux/debian/ bullseye: /usr/share/keyrings/docker-ce-archive-keyring.gpg != /usr/share/keyrings/docker-archive-keyring.gpg E: The list of sources could not be read. In either case; let's make sure that our script aligns with the manual steps that we document. [docker/docs@33befd6]: docker/docs@33befd6 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tianon
approved these changes
Jan 26, 2024
tianon-sso
approved these changes
Jan 26, 2024
dvdksn
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current distro versions now allow the GPG key to be stored as an
.ascfile, which simplifies installation. Changing the file extension for the GPG key to .asc lets apt-get know the GPG key is in ASCII armor format, in which case there is no need to "dearmor", and we no longer need gpg as a pre-requisite. Instructions for manual installation on Debian based distros were updated in our documentation through docker/docs@33befd6.It's common for users to install packages in a combination of the convenience script and manual (e.g. to update the packages after install, or vice-versa). Given that both the script and the manual steps configure the repository, we want those steps to align, otherwise (potentially?) warnings / errors may occur;
In either case; let's make sure that our script aligns with the manual steps that we document.