-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socket timeout when docker exec lasts too long #3124
Labels
Comments
I raised #3125 to resolve this issue. |
tonybart1337
added a commit
to supervisely/agent
that referenced
this issue
May 11, 2023
Fixed in 6.1.2. Thanks for raising the issue and fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since docker-py 6.1.0, using
container.exec_run
raises a socket.timeout exception if the command executed exceeds the timeout set on sockets when initialising the client.This can be reproduced with the following code:
This was introduced by this PR because the previous call to
select.select
would only listen for reads, whereas the call topoll.register
also listens to POLLOUT events.I guess there's a case for raising timeout errors but ignoring them was previously working just fine so in my eyes, no exception should be raised especially as the polling can wait until the socket really is available for read instead.
This has been reproduced with the following setup:
The text was updated successfully, but these errors were encountered: