Support building with Dockerfile outside of context #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
c5823-out-of-ctx-dockerfile
branch
from
5c6d557
to
cdbbb06
Compare
mefyl
reviewed
Mar 27, 2018
docker/utils/utils.py
Outdated
| if not fileobj: | ||
| fileobj = tempfile.NamedTemporaryFile() | ||
| t = tarfile.open(mode='w:gz' if gzip else 'w', fileobj=fileobj) | ||
| if files is None: | ||
| files = build_file_list(root) | ||
| for path in files: | ||
| if path in [e[0] for e in extra_files]: |
There was a problem hiding this comment.
Nitpicking, but any(e[0] == path for e in extra_files) won't build the whole list in memory. Maybe even building a set(e[0] for e in extra_files) before to avoid iterating too many times.
mefyl
approved these changes
Mar 27, 2018
Signed-off-by: Joffrey F <joffrey@docker.com>
|
Thank you for reviewing! 👍 |
|
Thanks @shin- ! (Not enough experience with python though to review 😅) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on docker/cli#886
Fixes docker/compose#5823