Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat with pip10+ #2002

Closed
wants to merge 1 commit into from
Closed

Compat with pip10+ #2002

wants to merge 1 commit into from

Conversation

kiorky
Copy link
Contributor

@kiorky kiorky commented Apr 23, 2018

This fixes #2001

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:corpusops/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

This fixes docker#2001

Signed-off-by: Mathieu Le Marec - Pasquet <kiorky@cryptelium.net>
@amancevice
Copy link

amancevice commented Apr 25, 2018

This might be a longer-term solution (in case pip changes again):

import pkg_resources

try:
    pkg_resources.get_distribution('docker-py')
    print(
        'ERROR: "docker-py" needs to be uninstalled before installing this'
        ' package:\npip uninstall docker-py', file=sys.stderr
    )
    sys.exit(1)
except pkg_resources.DistributionNotFound:
    pass

@shin-
Copy link
Contributor

shin- commented Apr 25, 2018

Thanks! I went ahead and removed the check altogether (accb9de) as I believe it is no longer useful.

@shin- shin- closed this Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker pip installation is broken with pip10+
4 participants