Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify Host Devices during container start #372

Closed
wants to merge 1 commit into from
Closed

Ability to specify Host Devices during container start #372

wants to merge 1 commit into from

Conversation

dims
Copy link
Contributor

@dims dims commented Oct 24, 2014

The command line and daemon started supporting --device
parameter during docker start a while ago in the following commit:
moby/moby@e855c4b

Since the command line looks like this,
--device=[] Add a host device to the container (e.g. --device=/dev/sdc:/dev/xvdc)
This patch allows a list of strings to be passed into the start() method
and we parse out the 3 components just like in the above mentioned commit

The command line and daemon started supporting --device
parameter during docker start a while ago in the following commit:
moby/moby@e855c4b

Since the command line looks like this,
--device=[] Add a host device to the container (e.g. --device=/dev/sdc:/dev/xvdc)
This patch allows a list of strings to be passed into the start() method
and we parse out the 3 components just like in the above mentioned commit
@shin-
Copy link
Contributor

shin- commented Oct 24, 2014

Thanks! _parse_devices should be placed in the utils module instead. =)

@dims dims closed this Oct 24, 2014
@dims dims deleted the support-devices branch October 24, 2014 11:03
@dims
Copy link
Contributor Author

dims commented Oct 24, 2014

Please see new pull request. my github-fu is broken, so ended up creating a fresh branch/PR.

#373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants