Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for pull as an option to docker build #421

Merged
merged 2 commits into from
Dec 15, 2014
Merged

Allow for pull as an option to docker build #421

merged 2 commits into from
Dec 15, 2014

Conversation

hammerdr
Copy link
Contributor

Signed-off-by: Derek Hammer derek.r.hammer@gmail.com

Signed-off-by: Derek Hammer <derek.r.hammer@gmail.com>
@yograterol
Copy link
Contributor

I need this feature :D @hammerdr 👍

@shin-
Copy link
Contributor

shin- commented Dec 15, 2014

Please add the argument at the end of the list! Other than that, LGTM =)

@hammerdr
Copy link
Contributor Author

By end of the list, do you mean documentation, params hash, or method arguments? :)

@shin-
Copy link
Contributor

shin- commented Dec 15, 2014

All of the above! ;) I was thinking of the method arguments specifically, as to not break for people who may depend on the arguments order/position.

@hammerdr
Copy link
Contributor Author

Fixed!

shin- added a commit that referenced this pull request Dec 15, 2014
Allow for pull as an option to docker build
@shin- shin- merged commit a7cce1d into docker:master Dec 15, 2014
@shin-
Copy link
Contributor

shin- commented Dec 15, 2014

Thanks!

@hammerdr hammerdr deleted the docker-build-pull branch December 15, 2014 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants