Added support for cgroup parent #716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -737,7 +738,7 @@ def start(self, container, binds=None, port_bindings=None, lxc_conf=None, | |||
| dns=None, dns_search=None, volumes_from=None, network_mode=None, | |||
| restart_policy=None, cap_add=None, cap_drop=None, devices=None, | |||
| extra_hosts=None, read_only=None, pid_mode=None, ipc_mode=None, | |||
| security_opt=None, ulimits=None): | |||
| security_opt=None, ulimits=None, cgroup_parent=None): | |||
There was a problem hiding this comment.
I'd argue against adding this - we've deprecated passing host config arguments in start, and will probably remove it entirely in a future version.
There was a problem hiding this comment.
@shin- Good to know. Can you please tell how cgroup_parent and other host config arguments be passed ?
There was a problem hiding this comment.
Gladly! You can see the documentation on that topic.
|
Applied a few fixes and merged manually. Thanks! |
This was referenced Sep 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds cgroup-parent support to docker-py, which will allow us to add cgroup-parent support inside compose.