Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved description for Hello-World #1012

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Conversation

ScottFred
Copy link
Contributor

Add more detail for people to be able to understand how to build the Hello World using FROM scratch.

Proposed changes

There was a big leap in understanding needed when reading the current page about using "From scratch" to build the hello-world.c code and being able to package it in a Docker image. After figuring out myself, I thought it would be good to share with the rest of the world here.

Adds more detail for people to be able to understand how to build the Hello World using FROM scratch.
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @londoncalling should take a look.

@mdlinville
Copy link

Actually I am going to merge this for now.

@mdlinville mdlinville merged commit a28e62e into docker:master Jan 18, 2017
@londoncalling
Copy link
Contributor

@mstanleyjones @ScottFred Thanks, looks great! I will test the commands as soon as I can, but will trust they work for now :-) Nice contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants