Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1014 by adding flag #1022

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Conversation

sanscontext
Copy link
Contributor

Closes #1014

Turns out we were missing a --no-trunc flag, so longer urls were getting truncated. @mstanleyjones or @thaJeztah, ptal?

Signed-off-by: LRubin lrubin@docker.com

Signed-off-by: LRubin <lrubin@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

does docker-cloud container port <some container> work as well? (not too familiar with the docker-cloud CLI (wondering if it has the equivalent to docker container port)

Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without much background in docker-cloud. I think the --no-trunc flag is relatively new in Engine, right @thaJeztah ?

@sanscontext
Copy link
Contributor Author

@thaJeztah We don't have docker-cloud container port command - the container commands are all things like start, stop, terminate. You could use docker-cloud container inspect but then you'd get the raw JSON, and if there are any service links that can run to many many pages.

@mstanleyjones if this is recent, then, awesome, we have a feature that fixes a bug in the current state of the world. :)

@sanscontext sanscontext merged commit e2be02a into docker:master Jan 4, 2017
@thaJeztah
Copy link
Member

--no-trunc for docker ps has been around for a long time, but for services it was recently added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants