Updating dockervolumes.md for Windows mounting #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code snippet for mounting Windows directories won't work: it will produce an "Invalid bind mount spec" error as Docker cannot properly read the path. The core error was addressed in [#12590](moby/moby#12590 (comment)), this is just an update to the tutorial.
FrenchBen
pushed a commit
to FrenchBen/docker.github.io
that referenced
this pull request
Jan 18, 2017
The format for node advertisement in swarm and docker engine (for networking) is the same, and can be shared. Doing so allows us to start toward removing the swarm-join container, and improves our HA situation after engine discovery is run. Resolves docker#670. Specifically, swarm was previously somewhat HA: if you set up 1 controller, 2 replicas and 1 node, then you could lose the controller and still remain functional unless the swarm node needed to restart. This change improves HA by removing the above failure mode as long as engine discovery has been run and is up to date. See also docker-archive/classicswarm#1368 which implemented this flag, and lays out the future scenario we hope to achieve, and also docker#1032 which is our goal of removing swarm join with automatical engine discovery.
FrenchBen
pushed a commit
to FrenchBen/docker.github.io
that referenced
this pull request
Jan 18, 2017
The format for node advertisement in swarm and docker engine (for networking) is the same, and can be shared. Doing so allows us to start toward removing the swarm-join container, and improves our HA situation after engine discovery is run. Resolves docker#670. Specifically, swarm was previously somewhat HA: if you set up 1 controller, 2 replicas and 1 node, then you could lose the controller and still remain functional unless the swarm node needed to restart. This change improves HA by removing the above failure mode as long as engine discovery has been run and is up to date. See also docker-archive/classicswarm#1368 which implemented this flag, and lays out the future scenario we hope to achieve, and also docker#1032 which is our goal of removing swarm join with automatical engine discovery.
bermudezmt
pushed a commit
that referenced
this pull request
May 22, 2019
1013 - Fix ToC indentation, missing images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The code snippet for mounting Windows directories won't work: it will produce an "Invalid bind mount spec" error as Docker cannot properly read the path. The core error was addressed in Docker issue #12590, this is just an update to the tutorial.
Unreleased project version (optional)
N/A
Related issues (optional)
moby/moby#12590 (comment)