Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image push reference #11071

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Update image push reference #11071

merged 2 commits into from
Jul 1, 2020

Conversation

usha-mandya
Copy link
Member

Made a minor update to the username (Docker ID) and description in the example

@usha-mandya usha-mandya requested a review from thaJeztah July 1, 2020 15:32
@usha-mandya usha-mandya mentioned this pull request Jul 1, 2020
Merged
@netlify
Copy link

netlify bot commented Jul 1, 2020 •
edited
Loading

Deploy preview for docsdocker ready!

Built with commit 9031d87

https://deploy-preview-11071--docsdocker.netlify.app

thaJeztah
thaJeztah reviewed Jul 1, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase letters are not supported on Docker Hub; do you think we should use hyphens? (I think those are supported)

@usha-mandya
Copy link
Member Author

I can update the example here to say 'your-dockerid`. Users will be made aware of the username requirements when they create an ID in Docker Hub. Not sure we want to capture those requirements here.

thaJeztah
thaJeztah previously approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way 😁

LGTM

@usha-mandya usha-mandya requested a review from thaJeztah July 1, 2020 15:58
thaJeztah
thaJeztah approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 89b17b2 into docker:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usha-mandya @thaJeztah