Skip to content

Wrong destination folder in container #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2016
Merged

Conversation

sicwolf
Copy link
Contributor

@sicwolf sicwolf commented Oct 8, 2016

/opt/webapp of web container includes app.py, if set destination folder as /opt/webapp, app.py is not visible and below error log presents and the web container will exit, so it's better to set the destination folder as /webapp.

docker logs -f web
python: can't open file 'app.py': [Errno 2] No such file or directory

"docker run -d -P --name web -v /src/webapp:/opt/webapp:ro training/webapp python app.py" this line aslo shall be update as "docker run -d -P --name web -v /src/webapp:/webapp:ro training/webapp python app.py"

/opt/webapp of web container includes app.py, if set destination folder as /opt/webapp, app.py is not visible and below error log presents, so it's better to set the destination folder as /webapp. 

docker logs -f web
python: can't open file 'app.py': [Errno 2] No such file or directory
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but you also need to change the references to /opt/webapp further down the topic, such as at line 106. Please be sure to change them all, and let me know when I can review it again.

Changed all wrong /opt/webapp as /webapp

/opt/webapp of web container includes app.py, if set destination folder as /opt/webapp, app.py is not visible and below error log presents and the web container will exit, so it's better to set the destination folder as /webapp.

docker logs -f web
python: can't open file 'app.py': [Errno 2] No such file or directory
@sicwolf
Copy link
Contributor Author

sicwolf commented Oct 11, 2016

Dear mstanleyjones,

All possible wrong /opt/webapp already changed in dockervolumes.md, could you pls. review the two commits related to this issue?
thank you so much for your review on my first contribution to docker project!

Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@mdlinville mdlinville merged commit cdaef77 into docker:master Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants