Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update engine reference docs #13106

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

thaJeztah
Copy link
Member

updating to the latest changes from the 20.10 branch

also includes the changes from docker/cli#3174 and docker/cli#3175 (soon to be merged)

updating to the latest changes from the 20.10 branch

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label Jul 2, 2021
@thaJeztah
Copy link
Member Author

@usha-mandya @mat007 PTAL

@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: 590463d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/60df2809135c7a000762418d

😎 Browse the preview: https://deploy-preview-13106--docsdocker.netlify.app

Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

image

@mat007
Copy link
Member

mat007 commented Jul 2, 2021

Actually clicking on the tooltip tries to open https://deploy-preview-13106--docsdocker.netlify.app/engine/deprecated/ which is a 404.
But maybe it’s because it’s a docs preview?

@thaJeztah
Copy link
Member Author

Yes, that's expected on the Netlify preview 👍

Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit 579323d into docker:master Jul 2, 2021
@thaJeztah thaJeztah deleted the update_engine_docs branch July 2, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants