Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: clarfiy daemon.json configuration for logging drivers #16752

Closed
wants to merge 1 commit into from

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Feb 20, 2023

Proposed changes

Clarify the location of daemon.json (differences between DD and Docker Engine) for configuring logging drivers on Docker Engine.

Related issues (optional)

#15106

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 234665d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/63ff191ac6ccba0008d1a993
😎 Deploy Preview https://deploy-preview-16752--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dvdksn dvdksn requested a review from thaJeztah February 20, 2023 20:37
@dvdksn dvdksn force-pushed the engine/clarify-daemonjson-loc-win branch from b4aaddb to 234665d Compare March 1, 2023 09:21
@dvdksn dvdksn requested a review from thaJeztah March 1, 2023 09:21
@thaJeztah
Copy link
Member

Hmm.. browsing the previous, I'm now wondered if we're still sending users back-and-forth now (bear with me);

On the page, we show links to "how to configure the daemon" (for desktop (mac/win/linux) or standalone);

Screenshot 2023-03-01 at 10 49 47

When clicking the "Desktop" links, it brings me to a section only describing where to set the daemon.json on Desktop, but no information "what to set there"

Screenshot 2023-03-01 at 10 53 26

And for "standalone", it brings me on another "round-trip"

Screenshot 2023-03-01 at 10 49 34

@thaJeztah
Copy link
Member

Wondering if we need to better separate "how to set the daemon.json", and "what to set in the daemon.json" 🤔

@docker-robott
Copy link
Collaborator

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@dvdksn
Copy link
Collaborator Author

dvdksn commented Jun 26, 2023

Closing this one in favor of a bigger refactoring of the daemon/config docs (I'm sure we will get to it at some point... 😄 )

@dvdksn dvdksn closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants