Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how IPv6-only works in Docker Desktop #20918

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Document how IPv6-only works in Docker Desktop #20918

wants to merge 1 commit into from

Conversation

akerouanton
Copy link
Member

@akerouanton akerouanton commented Sep 17, 2024 •
edited by dvdksn
Loading

Description

Document how the IPv4-only, IPv6-only and Dual-stack options work in Docker Desktop (starting from v4.35).

Preview

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 5afd08c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66f6bda1066b76000825f812
😎 Deploy Preview https://deploy-preview-20918--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Sep 17, 2024
djs55
djs55 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear, looks good to me!

dvdksn
dvdksn reviewed Sep 17, 2024
View reviewed changes
content/manuals/desktop/networking.md Outdated Show resolved Hide resolved
content/manuals/desktop/networking.md Outdated Show resolved Hide resolved
content/manuals/desktop/networking.md Outdated Show resolved Hide resolved
content/manuals/desktop/networking.md Outdated Show resolved Hide resolved
content/manuals/desktop/networking.md Outdated Show resolved Hide resolved
content/manuals/desktop/networking.md Outdated Show resolved Hide resolved
@aevesdocker aevesdocker added this to the 4.35 milestone Sep 17, 2024
@akerouanton akerouanton force-pushed the desktop-ipv6 branch 3 times, most recently from 69a6e75 to 18c426e Compare September 17, 2024 10:59
dvdksn
dvdksn previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn added the area/networking Relates to anything around networking label Sep 17, 2024
@akerouanton
Document how IPv6-only works in Docker Desktop
5afd08c 
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
@akerouanton akerouanton marked this pull request as draft October 22, 2024 08:06
@akerouanton
Copy link
Member Author

I've put this PR back in draft mode as it won't make it into v4.35.

@dvdksn Could you remove the milestone please?

@dvdksn dvdksn removed this from the 4.35 milestone Oct 22, 2024
@dvdksn dvdksn added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djs55 djs55 djs55 approved these changes

@dvdksn dvdksn dvdksn approved these changes

@aevesdocker aevesdocker Awaiting requested review from aevesdocker aevesdocker is a code owner

Assignees
No one assigned
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/networking Relates to anything around networking status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akerouanton @djs55 @dvdksn @aevesdocker