Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hub: add image library section #21485

Merged
merged 2 commits into from
Dec 16, 2024
Merged

hub: add image library section #21485

merged 2 commits into from
Dec 16, 2024

Conversation

craig-osterhout
Copy link
Contributor

@craig-osterhout craig-osterhout commented Nov 22, 2024 •
edited
Loading

Description

  • Added "Container image library" section in Docker Hub manual and started adding concepts.
    • Added section about search and all the filters
    • Added section about catalogs
    • Moved mirroring topic inside
  • Updated Hub landing page
  • Moved "Trusted content" into Repositories>Manage (for publishers) and Library (for consumers).

https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/search/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/catalogs/
https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/image-library/trusted-content/

https://deploy-preview-21485--docsdocker.netlify.app/docker-hub/repos/manage/trusted-content/

Related issues or tickets

ENGDOCS-2352

Reviews

  • Editorial review
  • Product review

@netlify Netlify
Copy link

netlify bot commented Nov 22, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit ddc3189
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/675b5f19fdfe5400077eccdc
😎 Deploy Preview https://deploy-preview-21485--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/hub Issue affects Docker Hub area/tests labels Nov 22, 2024
@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command area/security area/get-started Relates to get started and onboarding docs area/subscription Relates to Docker pricing and subscription labels Dec 3, 2024
@craig-osterhout craig-osterhout force-pushed the hub-library branch 2 times, most recently from 79e1e17 to 169f2f0 Compare December 3, 2024 22:39
@craig-osterhout
hub: add content library section
4367135 
Signed-off-by: Craig <craig.osterhout@docker.com>
@craig-osterhout craig-osterhout requested a review from a team December 10, 2024 22:45
@craig-osterhout craig-osterhout marked this pull request as ready for review December 10, 2024 22:45
@craig-osterhout craig-osterhout mentioned this pull request Dec 11, 2024
Merged
2 tasks
dvdksn
dvdksn reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

content/manuals/docker-hub/image-library/_index.md Outdated Show resolved Hide resolved
content/manuals/docker-hub/image-library/catalogs.md Outdated Show resolved Hide resolved
content/manuals/docker-hub/image-library/catalogs.md Outdated Show resolved Hide resolved
content/manuals/docker-hub/image-library/catalogs.md Outdated Show resolved Hide resolved
content/manuals/docker-hub/image-library/trusted-content.md Outdated Show resolved Hide resolved
content/manuals/docker-hub/image-library/trusted-content.md Outdated Show resolved Hide resolved
@craig-osterhout
feedback1
ddc3189 
Signed-off-by: Craig <craig.osterhout@docker.com>
dvdksn
dvdksn approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craig-osterhout craig-osterhout merged commit 44cce49 into docker:main Dec 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdksn dvdksn dvdksn approved these changes

Assignees
No one assigned
Labels
area/build Relates to Dockerfiles or docker build command area/get-started Relates to get started and onboarding docs area/hub Issue affects Docker Hub area/security area/subscription Relates to Docker pricing and subscription area/tests status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craig-osterhout @dvdksn