Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu.md #21654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ubuntu.md #21654

wants to merge 1 commit into from

Conversation

f1rf1n
Copy link

@f1rf1n f1rf1n commented Dec 17, 2024

Description

Instruction did not mention having to start the docker service before testing 'hello world'. Following the instruction (as-was) literally leads to confusing errors.

Updated doc accordingly.

  • Technical review
  • Editorial review
  • Product review

Instruction did not mention having to start the docker service before testing 'hello world'. Following the instruction literally leads to confusing errors.
@f1rf1n f1rf1n requested a review from dvdksn as a code owner December 17, 2024 19:13
@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product labels Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 862ded3
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6761cd4d3c72af00087ee0c9
😎 Deploy Preview https://deploy-preview-21654--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@f1rf1n
Copy link
Author

f1rf1n commented Dec 17, 2024

I just ran into this (on pop_os, a ubuntu-based distro) and into #16849

Is this is the instruction page for ubuntu, maybe it might be worth changing all references or mentions of sudo service docker start to sudo systemctl start docker no?

Or add something ( a tip? a note? a troubleshoot section?) to the page?

@dvdksn
Copy link
Collaborator

dvdksn commented Dec 18, 2024

I'd be open to adding a note about it, along the lines of:

Note

If you see the following error message:

docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? See 'docker run --help'.

This indicates that the Docker daemon is not running. You can start it manually by running the following command:

$ sudo systemctl enable --now docker

This command will start the Docker daemon immediately and ensure it starts automatically on system boot.

(+1 on changing sudo service to sudo systemctl)

@thaJeztah
Copy link
Member

Perhaps we could add to the existing note could work? We may want to avoid sprinkling too many notes in between, specifically because these would be for non-standard installations?

Screenshot 2024-12-18 at 10 03 49

Something like

The `docker` service does not start automatically after installation on some derivative and you may need to run `sudo systemctl start docker` after installation."

@dvdksn
Copy link
Collaborator

dvdksn commented Dec 18, 2024

@thaJeztah yeah I agree with the noise factor but that note is in the wrong place for this info. Plus a lot of users already miss that note.

@dvdksn
Copy link
Collaborator

dvdksn commented Dec 18, 2024

@thaJeztah you know what would fix all of this right? curl https://get.docker.com/ | bash 😄

@thaJeztah
Copy link
Member

I'm not sure the get.docker.com works with all derivatives (we had some code in there at some point, but all derivatives had their own issues, and we have no way of testing all flavours out there ... each with their own issues), which was one of the reasons we removed most mentions of derivatives as it was near impossible to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon area/install Relates to installing a product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants