Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Hyper-V and VirtualBox info for Docker for Windows #256

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Clarify Hyper-V and VirtualBox info for Docker for Windows #256

merged 1 commit into from
Oct 20, 2016

Conversation

mdlinville
Copy link

Describe the proposed changes

Reworded a couple spots to clarify the situation with Hyper-V and Virtualbox on Docker for Windows

Project version

n/a

Related issue

#134

Related issue or PR in another project

n/a

Please take a look

@londoncalling @engcheng

Copy link

@johndmulhausen johndmulhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asymmetry in the prescriptive text bugs me, but other than that this LGTM from a docs perspective. You aren't really changing the technical assertions, near as I can tell, so it may be that you can merge w/o technical feedback/


- Docker for Mac: You can create additional `docker-machine` machines using the
`virtualbox` driver.
- Docker for Windows: You can create additional `docker-machine` machines, but you

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simplify to:

Docker for Windows: You can create additional docker-machine machines using the hyperv driver.

@engcheng
Copy link

thanks, its certainly helps to avoid 1 misinterpretation 😄

Fixes #134

Signed-off-by: Misty Stanley-Jones <misty@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants