Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for Raspberry Pi #4315

Merged
merged 2 commits into from
Sep 11, 2017
Merged

Update instructions for Raspberry Pi #4315

merged 2 commits into from
Sep 11, 2017

Conversation

mdlinville
Copy link

Fixes #4292

Update instructions for Raspberry Pi to account for Stretch, consolidate instructions to use the recommended packages, a little light reorganization of the topic.

cc/ @andrewhsu @shin-

@gbarr01
Copy link
Contributor

gbarr01 commented Aug 22, 2017

@mstanleyjones, why don't we use a version number for Debian Stretch? For example, Stretch 9.1 (stable) / Raspbian Stretch.

@mdlinville
Copy link
Author

@gbarr01 I asked about this and it's just Debian convention. I think that Stretch is maybe the whole 9 line. See https://www.debian.org/releases/.

@gbarr01
Copy link
Contributor

gbarr01 commented Aug 30, 2017

@mstanleyjones , I asked about the convention because our entries for Jessie and Wheezy have version numbers.

@mdlinville
Copy link
Author

@seemethere PTAL

@seemethere
Copy link
Contributor

So unfortunately for raspbian, the latest release of 17.07.0-ce introduced a bug highlighted in moby/swarmkit#2294 which led us to using the installation script to install an older version of Docker (17.05.x-ce) that does not have this bug.

So installation for Raspbian proper is really only supported in the get.docker.com / test.docker.com script.

Also, the base url should be different for debian / raspbian.

Debian: https://download.docker.com/linux/debian
Raspbian: https://download.docker.com/linux/raspbian

My suggestion for right now would be to say that installation for raspbian is only currently supported through the convenience script and leave at that until we can fix the swarmkit bug.

@seemethere
Copy link
Contributor

Also I guess I can't make a comment on lines that haven't changed but this line:

{% assign download-url-base = "https://download.docker.com/linux/debian" %}

Should probably be changed to

{% assign download-url-base = "https://download.docker.com/linux/$(. /etc/os-release | echo "$ID")" %}

So that it can accommodate both raspbian and debian.

@mdlinville
Copy link
Author

@seemethere That's a Liquid (docs-build-time) variable, and doesn't have access to what is on the user's Docker host...

@seemethere
Copy link
Contributor

@mstanleyjones I understand that, but it'd be fine to leave that in since it is a shell command that can be run on the users system and is platform agnostic.

It's actually what is used in the get.docker.com install script as well.

So using it in that format should work no matter what:

Example:

curl -fsSL https://download.docker.com/linux/$(. /etc/os-release; echo "$ID")/gpg | sudo apt-key add -

Would actually run (on debian):

curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -

@mdlinville mdlinville merged commit 2569f75 into docker:master Sep 11, 2017
@mdlinville mdlinville deleted the 4292-pi-stretch branch September 11, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants