-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions for Raspberry Pi #4315
Conversation
@mstanleyjones, why don't we use a version number for Debian Stretch? For example, |
@gbarr01 I asked about this and it's just Debian convention. I think that Stretch is maybe the whole |
@mstanleyjones , I asked about the convention because our entries for Jessie and Wheezy have version numbers. |
@seemethere PTAL |
So unfortunately for raspbian, the latest release of 17.07.0-ce introduced a bug highlighted in moby/swarmkit#2294 which led us to using the installation script to install an older version of Docker (17.05.x-ce) that does not have this bug. So installation for Raspbian proper is really only supported in the get.docker.com / test.docker.com script. Also, the base url should be different for debian / raspbian. Debian: https://download.docker.com/linux/debian My suggestion for right now would be to say that installation for raspbian is only currently supported through the convenience script and leave at that until we can fix the swarmkit bug. |
Also I guess I can't make a comment on lines that haven't changed but this line:
Should probably be changed to
So that it can accommodate both |
@seemethere That's a Liquid (docs-build-time) variable, and doesn't have access to what is on the user's Docker host... |
@mstanleyjones I understand that, but it'd be fine to leave that in since it is a shell command that can be run on the users system and is platform agnostic. It's actually what is used in the get.docker.com install script as well. So using it in that format should work no matter what: Example: curl -fsSL https://download.docker.com/linux/$(. /etc/os-release; echo "$ID")/gpg | sudo apt-key add - Would actually run (on debian): curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add - |
Fixes #4292
Update instructions for Raspberry Pi to account for Stretch, consolidate instructions to use the recommended packages, a little light reorganization of the topic.
cc/ @andrewhsu @shin-