Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type of keywords entry in frontmatter (in /docker-hub/ dir) #498

Merged

Conversation

gdevillele
Copy link
Contributor

Describe the proposed changes

in /docker-hub/ :
change keywords's type from array to string.

Project version

current stable

Related issue

contributes to #435

Signed-off-by: Gaetan de Villele gdevillele@gmail.com

keywords should be a string, not an array containing one string

Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
@johndmulhausen
Copy link

johndmulhausen commented Nov 9, 2016

Deploy preview ready!

Built with commit e83a259

https://deploy-preview-498--docker-docs.netlify.com

thaJeztah pushed a commit to thaJeztah/docker.github.io that referenced this pull request Nov 9, 2016
- Close docker#194 and fix
- Fix and close docker#425
- Fix and close docker#417
- Fix and close docker#420
- Fix and close docker#422
- Adding in documentation build scripts
- Fix and close docker#431
- Fix and close docker#438, and Fix and close docker#429
- Work on 441
- Adding in commands reference
- Updating all the options to tables
- Updating per Vivek docker#498
- Adding vivek's last suggestions

Signed-off-by: Mary Anthony <mary@docker.com>
thaJeztah pushed a commit to thaJeztah/docker.github.io that referenced this pull request Nov 9, 2016
- Fixes docker#498
- Fixes docker#528
- Fixes docker#785
- Fixes docker#794
- Fixes docker#927
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And since I haven't said it already, thanks for doing this tedious migration work. :)

@sanscontext sanscontext merged commit 8717e0e into docker:master Nov 9, 2016
joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this pull request Nov 11, 2016
- Close docker#194 and fix
- Fix and close docker#425
- Fix and close docker#417
- Fix and close docker#420
- Fix and close docker#422
- Adding in documentation build scripts
- Fix and close docker#431
- Fix and close docker#438, and Fix and close docker#429
- Work on 441
- Adding in commands reference
- Updating all the options to tables
- Updating per Vivek docker#498
- Adding vivek's last suggestions

Signed-off-by: Mary Anthony <mary@docker.com>
joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this pull request Nov 11, 2016
- Fixes docker#498
- Fixes docker#528
- Fixes docker#785
- Fixes docker#794
- Fixes docker#927
joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this pull request Apr 16, 2018
JimGalasyn pushed a commit that referenced this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants