-
Notifications
You must be signed in to change notification settings - Fork 7.6k
WIP: Fix menu overflow #5574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix menu overflow #5574
Conversation
- Add toggle for night mode - Update base styles
Merge remote-tracking branch 'upstream/master'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few things:
-
The alignment of the search box on a full-width browser on the very front page seems weird. Shouldn't it left-align with the left-hand nav?
-
If you switch to another tab (like Product Manuals) and then back to the front page, you lose the search box entirely sometimes. This happened to me at least once but I couldn't reliably replicate it.
-
From 991-1024 px wide I don't have the archive drop-down at all even though I haven't switched into "mobile mode" so I don't have the hamburger either.
-
There is no way to select archive versions at all in the mobile view, unless you know that they are available at the bottom of the left nav. Maybe this is OK.
-
Around 785px and smaller, parts of the top nav (Guides / Product Manuals / Glossary etc) start disappearing and are not accessible in any way.
@MistyHacks - Thank you for the above comments/details! Going to take another crack at this 🌟 |
1025px - 1141px is weird because the top bar is still small (not the hero one) but its background is transitioning like the hero one does. I think this is not what we want. @jsouth |
Remove temp.css
@jsouth looks like you need to rebase on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost! 993-1000PX has no hamburger menu and also no drop-down version selector. I think the hamburger should probaby start at 1000 and go down. WDYT?
@MistyHacks - The hamburger menu is utilizing the default bootstrap breakpoints. We can override, but need to double check to be sure it won't effect anything negatively. will circle back! |
@MistyHacks - Would it be possible to merge what we have, and i"ll do some follow up fixes? please advise :) |
Sure, that sounds fine. I'm not sure why the hamburger menu is not behaving if it is just using the default Bootstrap breakpoints. I would prefer for us not to have to override the Bootstrap defaults in anyway. We can debug that 7-pixel gap in a follow-up! |
Fixes #5511
Fixes #5207
However, I would like to fine tune the actions on viewport rescaling a bit more.
More to come :)