Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "select a storage driver" with current status #7669

Merged
merged 6 commits into from
Nov 13, 2018

Conversation

thaJeztah
Copy link
Member

The information on this page was a bit outdated, and with "overlay" and "devicemapper" being phased-out, could use some changes;

  • de-emphasize "overlay", "devicemapper" and "aufs"
  • split "recommended" and "alternative drivers" columns
    (vfs was listed as a "recommended" driver, but definitely
    is not recommended for production use).
  • add notes about "overlay" and "devicemapper" being
    deprecated in Docker 18.09
  • some other textual changes.

Related issues (optional)

@thaJeztah
Copy link
Member Author

ping @ahh-docker @bermudezmt @mataneja PTAL

@thaJeztah
Copy link
Member Author

oh, and @L-Hudson 🤗

@GordonTheTurtle
Copy link

GordonTheTurtle commented Nov 12, 2018

Deploy preview for docsdocker ready!

Built with commit e7cbb50

https://deploy-preview-7669--docsdocker.netlify.com

@ahh-docker ahh-docker self-assigned this Nov 13, 2018
@ahh-docker
Copy link
Contributor

@thaJeztah Mind if I take some edits at this before sending them off to @L-Hudson for review?

@thaJeztah
Copy link
Member Author

@ahh-docker no, not at all; edit away; I started working on this, then saw the discussion that the docs team may started working on it, so I thought: let me push, and open as a PR.

The information on this page was a bit outdated, and
with "overlay" and "devicemapper" being phased-out, could
use some changes;

- de-emphasize "overlay", "devicemapper" and "aufs"
- split "recommended" and "alternative drivers" columns
  (vfs was listed as a "recommended" driver, but definitely
  is not recommended for production use).
- add notes about "overlay" and "devicemapper" being
  deprecated in Docker 18.09
- some other textual changes.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the update_select_a_storage_driver branch from d5baa72 to 3b24959 Compare November 13, 2018 17:04
Copy link
Member Author

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two nits, but otherwise your changes look good to me 👍

storage/storagedriver/select-storage-driver.md Outdated Show resolved Hide resolved
storage/storagedriver/select-storage-driver.md Outdated Show resolved Hide resolved
Copy link
Member Author

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahh-docker
Copy link
Contributor

Asking @bermudezmt or @ddeyo for peer review. Once I get a LGTM, I'll merge.

@bermudezmt
Copy link
Contributor

bermudezmt commented Nov 13, 2018

I spotted a few things that needed changing, and would like to get a review from @L-Hudson on the product naming especially around "Docker Engine Enterprise and Docker EE" and "Docker Engine Community and Docker CE".

@bermudezmt bermudezmt requested a review from a user November 13, 2018 19:11
@ahh-docker
Copy link
Contributor

@L-Hudson: Please give your final review and edits. Once it's done, lemme know so we can merge. Please tag myself and @thaJeztah with any questions. Thanks!

[Product compatibility matrix](https://success.docker.com/Policies/Compatibility_Matrix).
To get commercial support from Docker, you must use a supported configuration.

### Docker CE
### Docker Engine Community and Docker CE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shd be "Docker Engine - Community"


For Docker CE, only some configurations are tested, and your operating system's
kernel may not support every storage driver. In general, the following
For Docker Engine Community, only some configurations are tested, and your operating
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shd be "Docker Engine - Community"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed throughout.

Fixed product naming
@ahh-docker ahh-docker merged commit 2c0b5e2 into docker:master Nov 13, 2018
@thaJeztah thaJeztah deleted the update_select_a_storage_driver branch November 14, 2018 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants