genai-stack#103: "adds user directive to database service" #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine to me. I was concerned that this change might mean that existing users have to delete their current db volume and restart though. @oskarhane, is this safe? |
|
@slimslenderslacks what does the user directive do? I ist just linux user:group mapping? |
arfeifei
added a commit
to arfeifei/genai-stack
that referenced
this pull request
Jan 31, 2024
Lapeyus
pushed a commit
to Lapeyus/genai-stack
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Joseph Villarreal Lopez <joseph.villarreal@66degrees.com>
Lapeyus
pushed a commit
to Lapeyus/genai-stack
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Joseph Villarreal Lopez <joseph.villarreal@66degrees.com>
|
@jexp Ya, in general, doing less with the root user is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #103