Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display pull progress bar with docker compose up #55

Merged
merged 6 commits into from
Dec 22, 2023

Conversation

matthieuml
Copy link
Contributor

I realized that using docker compose logs showed the pull progress bar, but not while using docker compose up.

I added the tty: true parameter so that the full log of the pull-model service is displayed (including the pull progresss bar). It is not very "nice" as the colorful output of the docker compose up isn't there for this service, but it allows to see the progress bar.

Do you think it is worth it ?

@matthieuml matthieuml changed the title Allow the display pull progress with docker compose up Display pull progress bar with docker compose up Oct 21, 2023
Copy link
Collaborator

@slimslenderslacks slimslenderslacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I think it's worth merging this. The only reason this service is there is to provide a good terminal experience so it makes sense.

@slimslenderslacks slimslenderslacks merged commit a61f493 into docker:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants