Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing SCTP port mapping #41

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Support parsing SCTP port mapping #41

merged 1 commit into from
Feb 5, 2018

Conversation

ishidawataru
Copy link
Contributor

@ishidawataru ishidawataru commented Jul 3, 2017 •
edited by AkihiroSuda
Loading

please see moby/moby#33922
image

Signed-off-by: Wataru Ishida ishida.wataru@lab.ntt.co.jp

@ishidawataru ishidawataru mentioned this pull request Jul 3, 2017
Merged
4 tasks
@aaronlehmann aaronlehmann mentioned this pull request Jul 7, 2017
Merged
AkihiroSuda
AkihiroSuda approved these changes Feb 2, 2018
View reviewed changes
Copy link
Collaborator

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @docker/core-engine-cli-maintainers (who are maintainers of this repo now?)

@AkihiroSuda
Copy link
Collaborator

CI failure after rebase is unrelated

@AkihiroSuda
Copy link
Collaborator

opened #47

vdemeester
vdemeester approved these changes Feb 2, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮 (with a rebase)

@AkihiroSuda
Support parsing SCTP port mapping
61286a1 
Signed-off-by: Wataru Ishida <ishida.wataru@lab.ntt.co.jp>
@AkihiroSuda
Copy link
Collaborator

rebased

@vdemeester vdemeester merged commit f93969b into docker:master Feb 5, 2018
@thaJeztah thaJeztah mentioned this pull request Mar 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@aaronlehmann aaronlehmann aaronlehmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishidawataru @AkihiroSuda @vdemeester @aaronlehmann