-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated graphdriver-plugins, assorted cleanups, and update to go1.21 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, that was somewhat expected;
|
thaJeztah
changed the title
gha: update actions/checkout@v4
Remove deprecated graphdriver-plugins, and update to go1.21
Jun 30, 2024
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The experimental graphdriver plugins were deprecated in docker 27.0, and removed in docker 28.0. https://docs.docker.com/engine/deprecated/#graphdriver-plugins-experimental This removes the helpers for these kind of plugins, and updates the README accordingly. Also updated a link to the documentation. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
update_gha
branch
3 times, most recently
from
June 30, 2024 15:04
403e89d
to
3b3f4b8
Compare
thaJeztah
changed the title
Remove deprecated graphdriver-plugins, and update to go1.21
Remove deprecated graphdriver-plugins, assorted cleanups, and update to go1.21
Jun 30, 2024
thaJeztah
force-pushed
the
update_gha
branch
2 times, most recently
from
June 30, 2024 15:39
0997170
to
05b75c9
Compare
This was referenced Jun 30, 2024
Draft
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was added in 008703b, but none of the functions are exported, and none of them are currently called. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
laurazard
approved these changes
Jun 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gofmt, update to go1.21 and remove legacy build-tags
remove deprecated graphdriver-plugins (experimental)
The experimental graphdriver plugins were deprecated in docker 27.0, and
removed in docker 28.0. https://docs.docker.com/engine/deprecated/#graphdriver-plugins-experimental
This removes the helpers for these kind of plugins, and updates the README
accordingly. Also updated a link to the documentation.
volume/shim: remove unused testVolume
sdk: remove errOnlySupportedOnLinuxAndFreeBSD, errOnlySupportedOnWindows
sdk: add TODO for systemd socket-activation
It was added in 008703b, but none of the
functions are exported, and none of them are currently called.
sdk: remove empty test
sdk: fix GoDoc comments, and inline variable
remove uses of deprecated io/ioutil
gha: update actions/checkout@v4