Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated graphdriver-plugins, assorted cleanups, and update to go1.21 #138

Merged
merged 11 commits into from
Jul 1, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 30, 2024

gofmt, update to go1.21 and remove legacy build-tags

remove deprecated graphdriver-plugins (experimental)

The experimental graphdriver plugins were deprecated in docker 27.0, and
removed in docker 28.0. https://docs.docker.com/engine/deprecated/#graphdriver-plugins-experimental

This removes the helpers for these kind of plugins, and updates the README
accordingly. Also updated a link to the documentation.

volume/shim: remove unused testVolume

sdk: remove errOnlySupportedOnLinuxAndFreeBSD, errOnlySupportedOnWindows

sdk: add TODO for systemd socket-activation

It was added in 008703b, but none of the
functions are exported, and none of them are currently called.

sdk: remove empty test

sdk: fix GoDoc comments, and inline variable

remove uses of deprecated io/ioutil

gha: update actions/checkout@v4

@thaJeztah
Copy link
Member Author

Yeah, that was somewhat expected;

Pulling from library/golang
...
Digest: sha256:5f6a4662de3efc6d6bb812d02e9de3d8698eea16b8eb7281f03e6f3e8383018e
Status: Downloaded newer image for golang:1.16
+ install-deps
//go:build comment without // +build comment
make: *** [Makefile:19: install-deps] Error 1
make: *** [Makefile:15: test] Error 2
Error: Process completed with exit code 2.

@thaJeztah thaJeztah changed the title gha: update actions/checkout@v4 Remove deprecated graphdriver-plugins, and update to go1.21 Jun 30, 2024
@thaJeztah thaJeztah marked this pull request as ready for review June 30, 2024 13:54
@thaJeztah thaJeztah mentioned this pull request Jun 30, 2024
1 task
@thaJeztah thaJeztah self-assigned this Jun 30, 2024
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The experimental graphdriver plugins were deprecated in docker 27.0, and
removed in docker 28.0. https://docs.docker.com/engine/deprecated/#graphdriver-plugins-experimental

This removes the helpers for these kind of plugins, and updates the README
accordingly. Also updated a link to the documentation.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the update_gha branch 3 times, most recently from 403e89d to 3b3f4b8 Compare June 30, 2024 15:04
@thaJeztah thaJeztah changed the title Remove deprecated graphdriver-plugins, and update to go1.21 Remove deprecated graphdriver-plugins, assorted cleanups, and update to go1.21 Jun 30, 2024
@thaJeztah thaJeztah force-pushed the update_gha branch 2 times, most recently from 0997170 to 05b75c9 Compare June 30, 2024 15:39
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was added in 008703b, but none of the
functions are exported, and none of them are currently called.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 87005b1 into docker:main Jul 1, 2024
2 checks passed
@thaJeztah thaJeztah deleted the update_gha branch July 1, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants