-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify multiple tags per build #341
Comments
👍 I'd love to see this as well |
👍 please. This would greatly increase the speed of fetching our master and staging branches instead of having to look it up all the time. |
+1 I also want this feature for semantic versioning. |
@ChristopherBiscardi Now over a year later, is there any news on this? It's basically the only reason that prevents me from using automated builds. In most official repos it's standard to have aliases for |
Sorry @mikehaertl I don't work at Docker anymore and thus have no insight into their priorities. As for the official repos, they are pushed manually (thus you could achieve a similar effect through any CI provider, which is what I do now). |
@ChristopherBiscardi Oh, ok. Thanks for the update. But with a CI provider I still can't use the "automated build" repo on docker hub, right? Thing is, that they privilege those in their search results. So if you don't have an automated build repo, your public repo is listed quite at the end somewhere. |
@mikehaertl I'm not sure what qualifies as "Automated Build" anymore. I just tested pushing to an automated build repo I own under the Presumably you could fire a webhook when an Automated Build happens which triggers your CI platform of choice to pull the image, retag and push. |
From here
In my understanding that's because an automated build should ensure, that you can always check the sources of the build. Whereas if you push a build, the user will not know if there isn't malware included etc. That's why automated build are favoured when searching on docker hub. I don't know, why you where able to push to that repo, but given the above you shouldn't - maybe some permissive remains from your days at docker ;) ? |
Thanks for the feedback. We are in the process of adding support for specifying multiple tags from a single build, which will be available on Docker Cloud later this year. In the meantime, a workaround for pushing multiple tags from a single build on Docker Cloud is to use a
For more information on using hooks and running custom commands between phases of the build process, please see: https://docs.docker.com/docker-cloud/builds/advanced/ |
@pkennedyr But will this work with automated builds? As quoted above the docs say, you can not push to an "automated build" repo. |
@mikehaertl: Yes, the above workaround will work for automated builds - the doc is being updated to reflect that pushes are allowed on automated repositories. Apologies for the confusion. |
Can't wait for this feature! |
Multi tags are already supported in both, Hub and Docker Cloud. You can specify tags separated by commas like:
|
@pchico83 you mean I can do something like this:
? |
@Hronom Yes, you can use any supported regexp for every tag separated by commas. |
@pchico83 awesome, thanks, I'm also look now at docker cloud... |
@Hronom Thanks. Yes, I opened a doc issue last week to document all this. |
Any known issues with the Hub? I just tried |
@Kaixhin Looks like it is not supported in Hub. I would recommend to switch to Docker Cloud. |
@pchico83 If this is not going to be added to the Hub would you be able to add the |
Support for specifying multiple tags from a single build is now available in Docker Cloud. We encourage you to try out Docker Cloud as this is where you will find support for specifying multiple tags per build and many other auto-build features. Also, marking this thread as |
@pkennedyr, Please accept my apologies in advance if I missed something in the |
@MichaelSimons To specify multiple Docker Tags from a single build rule on Docker Cloud:
e.g. Note: We will be updating the Docker Cloud documentation shortly to provide further context and examples of how to use this feature. |
@pkennedyr, I was close with the syntax I was trying - I mistakenly had a space after the comma. Little surprised the space isn't ignored. Thanks for clarification! |
It allows creating the stable tags as allowed by Docker hub [1]. [1] docker/hub-feedback#341 Change-Id: I84909b20fc8b926eb5414db7d57100aaa6060f84 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
It allows creating the stable tags as allowed by Docker hub [1]. [1] docker/hub-feedback#341 Change-Id: I84909b20fc8b926eb5414db7d57100aaa6060f84 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
It allows creating the stable tags as allowed by Docker hub [1]. [1] docker/hub-feedback#341 Change-Id: I84909b20fc8b926eb5414db7d57100aaa6060f84 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
* Update docs/submodules/functest from branch 'stable/euphrates' - Add post_push hooks It allows creating the stable tags as allowed by Docker hub [1]. [1] docker/hub-feedback#341 Change-Id: I84909b20fc8b926eb5414db7d57100aaa6060f84 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
I tried using this feature: Docker Tag Name: Error: The documentation is quite clear regarding use of comma to support multiple tags per build. Please advice. |
I see the same issue |
Still doesn't work with a comma; the documentation states it should. |
Cannot seem to tag and push more than one image in the docker automated build hook. docker/hub-feedback#341 (comment) suggests pushing a second image (latest in our case) from the post_push hook as a workaround.
Cannot seem to tag and push more than one image in the docker automated build hook. docker/hub-feedback#341 (comment) suggests pushing a second image (latest in our case) from the post_push hook as a workaround.
As I was have having the same problem, I have switched to Docker Cloud; no issue since. |
@pkennedyr Why this ticket is still closed if if it obvious it does not work on cloud.docker.com? I have "latest,1.6" and I get the infamous |
Docker Hub and Docker Cloud should both seamlessly support multiple tags, like "latest,{\1}.{\2}.{\3},{\1}.{\2},{\1}" - that's the most common use case for both! I understand the Cloud is where Docker want us to go, but for those of us staying on Hub, you really should support this too. |
This does not to seem to work on Docker Cloud as advertised either. Trying to save an automated build with the Docker tag set to something like |
For me specifying |
Interesting, thank you. Maybe it's the order ( |
For those who are still Googling, this works for me on https://hub.docker.com |
Hi @ulope the problem might be with the sourceref variable. It worked for me on docker hub with |
@HendrikRoehm Ok thanks for the feedback. Will try that syntax. |
As per comments in moby/moby#4768, it would be handy to specify multiple tags for a specific build. For example, the most common case would be assigning both a version number (e.g. "7.5") and the "latest" tag. Another use case, as seen with Ubuntu images, is to have version numbers and names.
The text was updated successfully, but these errors were encountered: