Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ctrl+C in tag rm prompt #116

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Handle ctrl+C in tag rm prompt #116

merged 1 commit into from
Nov 12, 2020

Conversation

chris-crone
Copy link
Member

- What I did
Fix ctrl+C handling in tag rm prompt.

- How I did it
Read user input in goroutine so that we can handle the context being canceled.

- How to verify it

$ ./bin/hub-tool tag rm ccrone/alpine
Please type the name of your tag to confirm deletion: ccrone/alpine:latest
^CError: canceled

Fixes: #110

silvin-lubecki
silvin-lubecki approved these changes Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-crone
tag.rm: Stop reading user input on signal
59240c9 
Signed-off-by: Chris Crone <christopher.crone@docker.com>
@chris-crone chris-crone merged commit af35f75 into main Nov 12, 2020
@chris-crone chris-crone deleted the respect-sigint branch November 12, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@rumpl rumpl rumpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control+C not handled by prompt in hub-tool tag rm
3 participants
@chris-crone @rumpl @silvin-lubecki