2FA token expired #126
Merged
2FA token expired #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the token expires Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
chris-crone
approved these changes
Nov 19, 2020
internal/login/login.go
Outdated
Comment on lines
64
to
65
| reader := bufio.NewReader(streams.In()) | ||
| return reader.ReadString('\n') |
There was a problem hiding this comment.
This blocks the user from being able to ctrl + c, either here or in a follow up we should factor this code and use it: https://github.com/docker/hub-tool/blob/main/internal/commands/tag/rm.go#L77-L88
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes #122
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory)