fix user access token deletion (fix #186) #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: João Vanzuita <joaovanzuita@me.com>
converge
changed the title
internal/commands/token/rm.go
Outdated
| fmt.Fprintf(streams.Out(), ansi.Warn("WARNING: This action is irreversible.")+` | ||
| By confirming, you will permanently delete the access token. | ||
| Deleting a token will invalidate your credentials on all Docker clients currently authenticated with this token. | ||
| By confirming, you will permanently revoke and delete the access token. |
There was a problem hiding this comment.
About rephrasing the warning message, the original intent was to match Docker Hub UX:
There was a problem hiding this comment.
Logic looks good to me, just a small change needed in the warning message 👍
Thanks for your PR @converge 🙏
Signed-off-by: João Vanzuita <joaovanzuita@me.com>
Tks again for the review, these little details make a good difference in the overall user experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
As reported on #186, user token deletion is failing to delete user access tokens. The issue is caused by the missing username at the
hubClient.AuthConfig.Usernamestruct field, the confirmation step looks for the username to confirm, but the username information is empty/not set.- How I did it
At initialization, the
auth, err := store.GetAuth()is called, I got it in advance, and provided the authorization data to the struct.- How to verify it
hub-tool token createhub-tool token rm uuid-token- Description for the changelog
Fix user token deletion by adding missing authorization data to the hubClient.
- A picture of a cute animal (not mandatory)