This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
Added closing of event listener #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JeffDM PTAL |
| if (value && value.length) { | ||
| port = value[0].HostPort; | ||
| } | ||
| if (ip === 'docker.local') { |
There was a problem hiding this comment.
May have to wait for this one - Current link preview is broken when VPN is enabled
Signed-off-by: French Ben <me+git@frenchben.com>
FrenchBen
force-pushed
the
close-listener
branch
from
c36129f to
d0e490d
Compare
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the logs logic and event listener cleanup.
Signed-off-by: French Ben me+git@frenchben.com