-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Conversation
Signed-off-by: TeckniX <lokitek@gmail.com>
Signed-off-by: TeckniX <lokitek@gmail.com>
Signed-off-by: TeckniX <lokitek@gmail.com>
Signed-off-by: TeckniX <lokitek@gmail.com>
Great! Taking a look! Thanks @TeckniX |
b256b02
to
35ab197
Compare
Signed-off-by: TeckniX <lokitek@gmail.com>
All updated - let me know if anything seems out of place |
Taking another look - sorry for the delay since June. |
The code probably needs another update, since a few things were changes since then |
Is there any chance Kinematic automatically reads linking configuration from |
@caiofbpa If the link was created via command line, Kitematic should pick it up too - The issue however is that if any changes are made to the container within Kitematic, there's a good chance that link will disappear. |
@JeffDM I just tested this locally after merging in master; it still works and the tests pass. Any updates on getting this merged in? |
@nVitius Thanks for checking the branch and confirming that it works as expected 👍 - I just merged the latest master into this. |
The type-ahead probably shouldn't show the current container as an option. Though, if @TeckniX isn't working on this anymore, it's something that could be added after (if?) this is merged. |
@nVitius Good catch, I didn't think about typing in the current container name, as it seems that the user would understand that this isn't correct. I've got access to the repo and will make the adjustments next week. Thanks! |
@FrenchBen So did you get a chance to make those changes? |
@uatec It's on my list - I've been traveling and didn't get a chance to do anything with it. Thanks for the reminder 👍 |
Closing this in favor of networking introduced in 1.9 |
Containers can now be linked together!
Example:
/# env MARIADB_PORT=tcp://172.17.0.3:3306 MARIADB_PORT_3306_TCP=tcp://172.17.0.3:3306 HOSTNAME=1e54cecd0c2f SHLVL=1 HOME=/root MARIADB_NAME=/hello-world-nginx/mariadb MARIADB_ENV_MARIADB_VERSION=10.0.19+maria-1~wheezy PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin MARIADB_PORT_3306_TCP_ADDR=172.17.0.3 MARIADB_ENV_MYSQL_ROOT_PASSWORD=mariaaa PWD=/ MARIADB_PORT_3306_TCP_PORT=3306 MARIADB_PORT_3306_TCP_PROTO=tcp MARIADB_ENV_MARIADB_MAJOR=10.0