Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username required #18

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Username required #18

merged 2 commits into from
Oct 16, 2020

Conversation

crazy-max
Copy link
Member

Closes #17

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Contributor

@clarkbw clarkbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good to me! 2 lines of changes with many lines of tests 😄

@tonistiigi tonistiigi merged commit 39ef12f into docker:master Oct 16, 2020
@crazy-max crazy-max deleted the username-required branch October 17, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Must provide --username with --password-stdin
3 participants