Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test login against registries pt.2 #27

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Test login against registries pt.2 #27

merged 3 commits into from
Dec 17, 2020

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Nov 10, 2020 •
edited
Loading

Ref. #23

Now against:

  • AWS Elastic Container Registry (needs to create a private and public repo)
    • AWS_ACCOUNT_NUMBER
    • AWS_REGION
    • AWS_ACCESS_KEY_ID
    • AWS_SECRET_ACCESS_KEY

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

crazy-max and others added 3 commits November 18, 2020 18:47
@crazy-max
Test login against registries part 2
27c3146 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Merge branch 'master' into login-test-2
b17cf6a
@crazy-max
Update for public ECR
c718c79 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review December 17, 2020 10:28
@crazy-max crazy-max merged commit 9bed628 into docker:master Dec 17, 2020
@crazy-max crazy-max deleted the login-test-2 branch December 17, 2020 10:28
@crazy-max crazy-max mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-crone chris-crone Awaiting requested review from chris-crone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crazy-max