Handle Amazon ECR registries associated with other accounts

[crazy-max]

Fixes #39
Fixes docker/build-push-action#253

cc. @michaelb990

@davidski Can be tested with:

name: ci

on:
  push:
    branches: master

jobs:
  login:
    runs-on: ubuntu-latest
    steps:
      -
        name: Login to ECR
        uses: crazy-max/docker-login-action@registry-ids
        with:
          registry: <aws-account-number>.dkr.ecr.<region>.amazonaws.com
          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        env:
          AWS_ACCOUNT_IDS: 012345678910,023456789012

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

[michaelb990]

It might be easier to write a function in the aws.ts similar to getRegion that just parses the registry URL for the account ID (it will always be the first token in the URL), this way users don't have to pass the registry ID twice.

https://github.com/docker/login-action/blob/master/src/aws.ts#L17

Either way, thanks for the quick turnaround! 🎉

[crazy-max]

@michaelb990 Ok got it! I've made some changes, let me know if it lgty. Thanks again!

[michaelb990]

Added 1 comment. Looks good other than that.

[michaelb990]

LGTM