ensure passwords are redacted with registry-auth#911
Merged
crazy-max merged 2 commits intodocker:masterfrom Jan 7, 2026
Merged
ensure passwords are redacted with registry-auth#911crazy-max merged 2 commits intodocker:masterfrom
crazy-max merged 2 commits intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Jan 6, 2026
Member
|
@crazy-max Just a reminder that in some cases masking too many things as secret can leak the variable. Eg. if you see |
Member
Author
Yes true, that's why we switched from |
mergify bot
added a commit
to ArcadeData/arcadedb
that referenced
this pull request
Feb 2, 2026
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.6.0 to 3.7.0. Release notes *Sourced from [docker/login-action's releases](https://github.com/docker/login-action/releases).* > v3.7.0 > ------ > > * Add `scope` input to set scopes for the authentication token by [`@crazy-max`](https://github.com/crazy-max) in [docker/login-action#912](https://redirect.github.com/docker/login-action/pull/912) > * Add support for AWS European Sovereign Cloud ECR by [`@dphi`](https://github.com/dphi) in [docker/login-action#914](https://redirect.github.com/docker/login-action/pull/914) > * Ensure passwords are redacted with `registry-auth` input by [`@crazy-max`](https://github.com/crazy-max) in [docker/login-action#911](https://redirect.github.com/docker/login-action/pull/911) > * build(deps): bump lodash from 4.17.21 to 4.17.23 in [docker/login-action#915](https://redirect.github.com/docker/login-action/pull/915) > > **Full Changelog**: <docker/login-action@v3.6.0...v3.7.0> Commits * [`c94ce9f`](docker/login-action@c94ce9f) Merge pull request [#915](https://redirect.github.com/docker/login-action/issues/915) from docker/dependabot/npm\_and\_yarn/lodash-4.17.23 * [`8339c95`](docker/login-action@8339c95) Merge pull request [#912](https://redirect.github.com/docker/login-action/issues/912) from docker/scope * [`c83e932`](docker/login-action@c83e932) build(deps): bump lodash from 4.17.21 to 4.17.23 * [`b268aa5`](docker/login-action@b268aa5) chore: update generated content * [`a603229`](docker/login-action@a603229) documentation for scope input * [`7567f92`](docker/login-action@7567f92) Add scope input to set scopes for the authentication token * [`0567fa5`](docker/login-action@0567fa5) Merge pull request [#914](https://redirect.github.com/docker/login-action/issues/914) from dphi/add-support-for-amazonaws.eu * [`f6ef577`](docker/login-action@f6ef577) feat: add support for AWS European Sovereign Cloud ECR registries * [`916386b`](docker/login-action@916386b) Merge pull request [#911](https://redirect.github.com/docker/login-action/issues/911) from crazy-max/ensure-redact * [`5b3f94a`](docker/login-action@5b3f94a) chore: update generated content * Additional commits viewable in [compare view](docker/login-action@5e57cd1...c94ce9f) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just for extra safety. It should not matter as secrets passed to
passwordattribute inregistry-authYAML object are already redacted.