The parentheses are needed for the shell commands to be executed properly.

[mshindo]

If the shell command looks like

"condition1 && command1 || condition2 && command2 || command3"

then condition2 will never be checked if condition1 is true and command1
exists normally. In order for this code to run expectedly, it should look
like

"(condition1 && command1) || (condition2 && command2) || command3"

instead.

Specifically, with the code like

"[ ! -d /Users ]&& sudo mkdir /Users; sudo mount --bind /mnt/hgfs/Users /Users || [ -f /usr/local/bin/vmhgfs-fuse ]&& sudo /usr/local/bin/vmhgfs-fuse -o allow_other .host:/Users /Users || sudo mount -t vmhgfs -o uid=$(id -u),gid=$(id -g) .host:/Users /Users"

if both "[ ! -d /Users ]" and "sudo mkdir /Users; sudo mount --bind
/mnt/hgfs/Users /Users" are true, then the existence of a file
/usr/local/bin/vmhgfs-fuse will never be examined and always be executed
even if the file doesn't exist. Consequently, it always fails.

[GordonTheTurtle]

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fusion-driver-fix" git@github.com:mshindo/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

[mshindo]

Gordon, Thanks for the instruction and sorry for not following the convention. I hope this time is OK. If there's still any problem, please let me know. Thanks. Regards, Motonori Shindo 2018年5月25日(金) 0:30 Gordon <notifications@github.com>:

…

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit: $ git clone -b "fusion-driver-fix" ***@***.***:mshindo/machine.git somewhere $ cd somewhere $ git commit --amend -s --no-edit $ git push -f Amending updates the existing PR. You *DO NOT* need to open a new one. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4491 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALKOx_QqoqAwMiROEeG4w_DMcMu0YKvks5t1tIkgaJpZM4UMe14> .

[dgageot]

LGTM