-
Notifications
You must be signed in to change notification settings - Fork 127
Add post command tips #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Left a few nitpicks. I think it might be a good idea for @docker/ui-copy to also take a look.
Also I believe the known feature flag you suggested is a good idea. Feel free to implement it in here or in another PR 🙏
cmd/docker-mcp/client/connect.go
Outdated
| return err | ||
| } | ||
| fmt.Printf("You might have to restart '%s'.\n", vendor) | ||
| fmt.Println("\033[36mTip: Your client is now connected! Try \033[1;3m'docker mcp tools ls'\033[0;36m to see available tools\033[0m") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: I think at this point we should also encourage them to go to the client and use the servers/tools in there.
@docker/ui-copy can we get some help in here? I want us to say "Go to your client to use your tools OR try docker mcp tools ls to see which ones are available`
cmd/docker-mcp/commands/server.go
Outdated
| fmt.Fprintln(cmd.OutOrStdout(), "No server is enabled") | ||
| } else { | ||
| fmt.Fprintln(cmd.OutOrStdout(), strings.Join(list, ", ")) | ||
| fmt.Fprintln(cmd.OutOrStdout(), "\033[36mTip: Connect to Claude/Cursor to use these servers with \033[1;3m'docker mcp client connect <client-name>'\033[0m") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: We do support many clients so I want us to not sound as if we are limited to just those two:
| fmt.Fprintln(cmd.OutOrStdout(), "\033[36mTip: Connect to Claude/Cursor to use these servers with \033[1;3m'docker mcp client connect <client-name>'\033[0m") | |
| fmt.Fprintln(cmd.OutOrStdout(), "\033[36mTip: Connect to your client (ex. Claude/Cursor) to use these servers with \033[1;3m'docker mcp client connect <client-name>'\033[0m") |
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did

docker mcp tools lsdocker mcp tools countdocker mcp client connect <client-name>docker mcp severs lsdocker mcp server enable <server-name>docker mcp server disable <server-name>docker mcp catalog lsdocker mcp catalog show